Repository navigation
hardwared: don't gate onroad on device registration - #23
Merged
Merged
Conversation
pre-AP Teslas run on non-comma hardware (e.g. Konik) that never registers with comma's backend, so a missing dongle id shouldn't keep the car offroad. drop the registered_device startup gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Konik A1 devices lose their comma dongle id when NAP flashes AGNOS 17.2, so
DongleIdstaysUnregisteredDeviceand the stockregistered_devicestartup gate never lets the car go onroad.comma's own comment in
hardwared.pyalready invites forks to skip this check. This drops it, same as sunnypilot. Ignition and the rest of the startup conditions are unchanged. Unregistered devices still skip athenad/uploader in manager.Change
startup_conditions["registered_device"]fromsystem/hardware/hardwared.pyPCandUNREGISTERED_DONGLE_IDimportsPort of
f49e32ae28fromno-gate, which already ran on a Konik A1.This is also on
nap-alpha(6d2af1607d) so testers can pick it up without waiting on this PR.